fix blocking getcwd on async playwright #3021
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: avoid blocking os.getcwd() call in async subprocess creation asyncio.create_subprocess_exec() internally calls os.getcwd() when the cwd parameter is not specified. This blocking call causes issues in ASGI servers that detect and prevent blocking operations on the event loop. This fix pre-fetches the current working directory using asyncio.to_thread() and passes it explicitly to create_subprocess_exec(), avoiding the blocking call during subprocess creation.
omerporze
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: avoid blocking os.getcwd() call in async subprocess creation
asyncio.create_subprocess_exec() internally calls os.getcwd() when the
cwd parameter is not specified. This blocking call causes issues in ASGI
servers that detect and prevent blocking operations on the event loop.
This fix pre-fetches the current working directory using asyncio.to_thread()
and passes it explicitly to create_subprocess_exec(), avoiding the blocking
call during subprocess creation.