Skip to content

Commit 10fbbbc

Browse files
authored
test(mcp): await fetches in network tests to fix flake (#40553)
1 parent ae57331 commit 10fbbbc

1 file changed

Lines changed: 21 additions & 9 deletions

File tree

tests/mcp/network.spec.ts

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -67,15 +67,22 @@ test('browser_network_requests', async ({ client, server }) => {
6767
});
6868

6969
test('browser_network_requests filter', async ({ client, server }) => {
70-
server.setContent('/', `<script>
71-
Promise.all([fetch('/api/users'), fetch('/api/orders'), fetch('/static/image.png')]);
72-
</script>`, 'text/html');
70+
server.setContent('/', '', 'text/html');
7371

7472
await client.callTool({
7573
name: 'browser_navigate',
7674
arguments: { url: server.PREFIX },
7775
});
7876

77+
await client.callTool({
78+
name: 'browser_evaluate',
79+
arguments: {
80+
function: `async () => {
81+
await Promise.all([fetch('/api/users'), fetch('/api/orders'), fetch('/static/image.png')]);
82+
}`,
83+
},
84+
});
85+
7986
{
8087
const response = parseResponse(await client.callTool({
8188
name: 'browser_network_requests',
@@ -88,18 +95,23 @@ test('browser_network_requests filter', async ({ client, server }) => {
8895
});
8996

9097
test('browser_network_requests numbers requests with stable indexes', async ({ client, server }) => {
91-
server.setContent('/', `<script>
92-
(async () => {
93-
await fetch('/api/users');
94-
await fetch('/api/orders');
95-
})();
96-
</script>`, 'text/html');
98+
server.setContent('/', '', 'text/html');
9799

98100
await client.callTool({
99101
name: 'browser_navigate',
100102
arguments: { url: server.PREFIX },
101103
});
102104

105+
await client.callTool({
106+
name: 'browser_evaluate',
107+
arguments: {
108+
function: `async () => {
109+
await fetch('/api/users');
110+
await fetch('/api/orders');
111+
}`,
112+
},
113+
});
114+
103115
// Index assignment is stable across calls — the same request keeps the same number.
104116
const response = parseResponse(await client.callTool({
105117
name: 'browser_network_requests',

0 commit comments

Comments
 (0)