Skip to content

test(mcp): await fetches in network tests to fix flake#40553

Merged
yury-s merged 1 commit into
microsoft:mainfrom
yury-s:fix-mcp-network-test-flake
Apr 30, 2026
Merged

test(mcp): await fetches in network tests to fix flake#40553
yury-s merged 1 commit into
microsoft:mainfrom
yury-s:fix-mcp-network-test-flake

Conversation

@yury-s
Copy link
Copy Markdown
Member

@yury-s yury-s commented Apr 30, 2026

Summary

  • The filter and stable indexes network tests fired fetches from inline <script> tags and immediately checked browser_network_requests, racing the responses.
  • Moved the fetches into browser_evaluate so the call resolves only after they complete.

The 'filter' and 'stable indexes' tests fired fetches from inline
<script> tags and immediately checked browser_network_requests, racing
the network responses. Move the fetches into browser_evaluate so the
call resolves only after they complete.
@yury-s yury-s merged commit 10fbbbc into microsoft:main Apr 30, 2026
15 of 16 checks passed
@yury-s yury-s deleted the fix-mcp-network-test-flake branch April 30, 2026 23:49
@github-actions
Copy link
Copy Markdown
Contributor

Test results for "MCP"

13 failed
❌ [firefox] › mcp/cli-devtools.spec.ts:217 › video-start-stop @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-devtools.spec.ts:231 › video-chapter @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-json.spec.ts:177 › close-all after open returns closed sessions @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:124 › daemon show: closing page exits the process @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:165 › should capture annotations via show --annotate @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:186 › should start dashboard and annotate when no dashboard is running @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:208 › should enter annotate mode on fresh dashboard.tsx mount with annotate @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:232 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:265 › should cancel browser_annotate when the MCP request is aborted @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:296 › should cancel browser_annotate when the MCP client disconnects @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:325 › should switch screencast to -s session on show --annotate @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:374 › should disengage annotate mode when --annotate client disconnects @mcp-windows-latest-firefox
❌ [firefox] › mcp/dashboard.spec.ts:441 › save recording streams WebM bytes to the chosen file @mcp-windows-latest-firefox

6850 passed, 1015 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants