fix(html reporter): skip img bits with non-images#11188
Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom Jan 5, 2022
Merged
fix(html reporter): skip img bits with non-images#11188pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman merged 1 commit intomicrosoft:mainfrom
Conversation
Regarding backwards compatibility: The image block will no longer show up in cases where no extension is used (see test case), but I think this is OK since you would have never hit the actual image comparison in the test if you omitted an extension: https://github.com/microsoft/playwright/blob/328f3e265efe9c431ebae1ed3d7fd47dcd547b29/packages/playwright-test/src/matchers/golden.ts#L44 before. Depending on how Visual Testing evolves, a follow up PR is due to clean up regferences to images. Fixes microsoft#11183
rwoll
commented
Jan 5, 2022
|
|
||
| {expected && actual && <AutoChip header='Image mismatch'> | ||
| <ImageDiff actual={actual} expected={expected} diff={diff}></ImageDiff> | ||
| {expected && actual && <AutoChip header={`${hasImages ? 'Image' : 'Snapshot'} mismatch`}> |
Member
Author
There was a problem hiding this comment.
We leave this block since it is convenient to be able to download the expected/actual/diff attachments regardless of their content type.
pavelfeldman
approved these changes
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding backwards compatibility: The image block will no longer show
up in cases where no extension is used (see test case), but I think this
is OK since you would have never hit the actual image comparison in the
test if you omitted an extension:
playwright/packages/playwright-test/src/matchers/golden.ts
Line 44 in 328f3e2
Depending on how Visual Testing evolves, a follow up PR is due to clean
up references to images.
Fixes #11183