feat: basic d.ts file#161
Merged
JoelEinbinder merged 2 commits intomicrosoft:masterfrom Dec 6, 2019
JoelEinbinder:basic_dts
Merged
feat: basic d.ts file#161JoelEinbinder merged 2 commits intomicrosoft:masterfrom JoelEinbinder:basic_dts
JoelEinbinder merged 2 commits intomicrosoft:masterfrom
JoelEinbinder:basic_dts
Conversation
dgozman
approved these changes
Dec 6, 2019
| @@ -0,0 +1,7 @@ | |||
| import * as chromium from './chromium'; | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
protocol.d.tshad to move toprotocol.tsotherwise typescript refuses to include it in the out directory.Removed the old d.ts generator. It will need to be rewritten anyway.
These new types include private stuff that they probably shouldn't, and are missing documentation. I'll follow up with a better d.ts generator later.
#6