Skip to content

feat(trace-viewer): add parameters copy to clip#19662

Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom
kriku:main
Dec 29, 2022
Merged

feat(trace-viewer): add parameters copy to clip#19662
pavelfeldman merged 1 commit intomicrosoft:mainfrom
kriku:main

Conversation

@kriku
Copy link
Copy Markdown
Contributor

@kriku kriku commented Dec 22, 2022

Add copy to clipboard icon near parameters value

Screenshot 2022-12-28 at 14 37 46

This patch adds copy icon at the right of string, number and object values.

On line hover:

Screenshot 2022-12-28 at 14 34 34

Click copies value to clipboard and changes current icon to check:

Screenshot 2022-12-28 at 14 36 13

Fixes #19582

@kriku
Copy link
Copy Markdown
Contributor Author

kriku commented Dec 22, 2022

@microsoft-github-policy-service agree

@kriku
Copy link
Copy Markdown
Contributor Author

kriku commented Dec 23, 2022

@pavelfeldman

hi! could you please help me out? who can I request for review?

@pavelfeldman
Copy link
Copy Markdown
Member

This looks nice! Do you think you could make it appear on hovered rows only?

@kriku
Copy link
Copy Markdown
Contributor Author

kriku commented Dec 28, 2022

This looks nice! Do you think you could make it appear on hovered rows only?

Sure. Already updated

@kriku kriku force-pushed the main branch 2 times, most recently from 32caf03 to 6580d7a Compare December 28, 2022 15:18
Add copy to clipboard icon near parameters value

Fixes microsoft#19582
@pavelfeldman pavelfeldman merged commit 166a729 into microsoft:main Dec 29, 2022
whazor pushed a commit to whazor/playwright-trace-viewer-plus that referenced this pull request Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trace Viewer - Test parameters copy functionality

2 participants