feat(chromium): allow to adjust output video quality#22257
Closed
SomaticIT wants to merge 1 commit into
Closed
Conversation
Author
|
@microsoft-github-policy-service agree company="Touchify" |
yury-s
reviewed
Apr 7, 2023
Member
yury-s
left a comment
There was a problem hiding this comment.
Thanks for the PR. Can you start with filing a feature request describing the use case so that we can evaluate what API we may need and how it will work in other browsers (you likely noticed that we don't use ffmpeg in webkit and firefox and these options won't work there as is).
Member
|
Closing this PR for now as part of housekeeping. Per the comment above we need to figure out a coherent story working across browsers first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Team,
Thank you for your amazing work on this project. I use it on different projects and it's very powerful.
Short description
This PR allows to configure output video quality on Chromium.
Background
Recently, I tried to generate videos based on HTML5 animation. I tried to use playwright to generate the video but unfortunately, the quality is not sufficient.
I also plan to use playwright to generate "support" videos for a product knowledge base.
Use cases
Additional notes
This feature is only available for Chromium. It's OK for my use case but maybe we can add it on other platforms.
It's my first PR on playwright. Do not hesitate to tell me if everything is correct.