Skip to content

feat(chromium): allow to adjust output video quality#22257

Closed
SomaticIT wants to merge 1 commit into
microsoft:mainfrom
SomaticIT:add-video-quality-params
Closed

feat(chromium): allow to adjust output video quality#22257
SomaticIT wants to merge 1 commit into
microsoft:mainfrom
SomaticIT:add-video-quality-params

Conversation

@SomaticIT
Copy link
Copy Markdown

Hello Team,

Thank you for your amazing work on this project. I use it on different projects and it's very powerful.

Short description

This PR allows to configure output video quality on Chromium.

Background

Recently, I tried to generate videos based on HTML5 animation. I tried to use playwright to generate the video but unfortunately, the quality is not sufficient.

I also plan to use playwright to generate "support" videos for a product knowledge base.

Use cases

  • Generate videos from HTML5 animation
  • Automate "how-to" videos
  • Automate "demonstration" videos
  • Reduce quality when recording tests

Additional notes

  • This feature is only available for Chromium. It's OK for my use case but maybe we can add it on other platforms.

  • It's my first PR on playwright. Do not hesitate to tell me if everything is correct.

@SomaticIT
Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree company="Touchify"

Copy link
Copy Markdown
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Can you start with filing a feature request describing the use case so that we can evaluate what API we may need and how it will work in other browsers (you likely noticed that we don't use ffmpeg in webkit and firefox and these options won't work there as is).

@yury-s
Copy link
Copy Markdown
Member

yury-s commented May 22, 2023

Closing this PR for now as part of housekeeping. Per the comment above we need to figure out a coherent story working across browsers first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants