fix(pause): ignore page.pause on the server#23417
Merged
dgozman merged 1 commit intomicrosoft:mainfrom Jun 2, 2023
Merged
Conversation
gskierk
reviewed
Jun 1, 2023
| if (require('inspector').url()) | ||
| return; | ||
| if (this._connection.isRemote()) | ||
| return; |
There was a problem hiding this comment.
Wouldn't any console.log about skipped execution be helpful in this case? Then the user will know that there are some unexpected pauses in the code.
yury-s
approved these changes
Jun 1, 2023
pavelfeldman
approved these changes
Jun 1, 2023
dgozman
force-pushed
the
ignore-pause-when-remote
branch
from
8a1b98f to
3f373bf
Compare
dgozman
changed the title
page.pause when connection is remotepage.pause on the server
Contributor
|
"tests 1" report. |
Contributor
|
"tests 1" report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23051.