chore: introduce chromium-tip-of-tree-headless-shell#33964
Merged
mxschmitt merged 2 commits intomicrosoft:mainfrom Dec 12, 2024
Merged
chore: introduce chromium-tip-of-tree-headless-shell#33964mxschmitt merged 2 commits intomicrosoft:mainfrom
mxschmitt merged 2 commits intomicrosoft:mainfrom
Conversation
mxschmitt
force-pushed
the
introduce-chromium-tip-of-tree-headless-shell
branch
from
4ff4cdd to
6ceac06
Compare
This comment has been minimized.
This comment has been minimized.
yury-s
reviewed
Dec 12, 2024
| headlessShellBrowser.revision = revision; | ||
| headlessShellBrowser.browserVersion = browserVersion; | ||
| } else if (browserName === 'chromium-tip-of-tree') { | ||
| const tipOfTreeBrowser = await browsersJSON.browsers.find(b => b.name === 'chromium-tip-of-tree-headless-shell'); |
Member
There was a problem hiding this comment.
Why can't we just use version of chromium-tip-of-tree, we don't expect these two to ever diverge, do we?
This comment has been minimized.
This comment has been minimized.
yury-s
approved these changes
Dec 12, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"10 failed 7 flaky37129 passed, 646 skipped Merge workflow run. |
Contributor
Test results for "tests others"1 flaky21293 passed, 509 skipped Merge workflow run. |
Contributor
Test results for "tests 2"1 fatal errors, not part of any test 93 flaky262979 passed, 10099 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: This helps us to find out about upstream headless_shell regressions before they appear in the Beta channel.
I was considering doing the same pattern like we do for chromium (auto use headless-shell) but this doesn't work here since
chromium-tip-of-treeis already a channel. Lets keep it how it is and do the manual opt-in.