devops(testrunner): support source maps#340
Merged
aslushnikov merged 1 commit intomicrosoft:masterfrom Jan 8, 2020
aslushnikov:testrunner-source-map-support
Merged
devops(testrunner): support source maps#340aslushnikov merged 1 commit intomicrosoft:masterfrom aslushnikov:testrunner-source-map-support
aslushnikov merged 1 commit intomicrosoft:masterfrom
aslushnikov:testrunner-source-map-support
Conversation
Contributor
There was a problem hiding this comment.
can we read the bottom of the file to parse out the map location, instead of assuming it is filename.map?
This patch adds a basic source map support to test runner. SourceMap support is powered by Chromium DevTools source map implementation (thus copyright). Unlike popular `source-map` npm module, it's sync and pretty straight-forward. The `SourceMap.js` file has a few modifications wrt upstream Chromium version: - reverse mappings API is removed. There's no need to ever compute them - the `upperBoundary` function from DevTools' platform is inlined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a basic source map support to test runner.
SourceMap support is powered by Chromium DevTools source map
implementation (thus copyright). Unlike popular
source-mapnpmmodule, it's sync.
The
SourceMap.jsfile has a few modifications wrt upstreamChromium version:
upperBoundaryfunction from DevTools' platform is inlinedpathto resolve source paths