Skip to content

Revert "chore(docs): clarify connection method via BrowserType.connect (#34560)"#34594

Merged
mxschmitt merged 1 commit intomicrosoft:mainfrom
mxschmitt:revert-1936cfa6c3f345c6e0a2b88039433bb045f3895f
Feb 3, 2025
Merged

Revert "chore(docs): clarify connection method via BrowserType.connect (#34560)"#34594
mxschmitt merged 1 commit intomicrosoft:mainfrom
mxschmitt:revert-1936cfa6c3f345c6e0a2b88039433bb045f3895f

Conversation

@mxschmitt
Copy link
Contributor

This reverts commit 1936cfa. It broke language ports (Python) which then saw the connect method without any other params on it.

@mxschmitt mxschmitt merged commit 3d5f85d into microsoft:main Feb 3, 2025
28 of 29 checks passed
@mxschmitt mxschmitt deleted the revert-1936cfa6c3f345c6e0a2b88039433bb045f3895f branch February 3, 2025 13:24
mxschmitt added a commit that referenced this pull request Feb 3, 2025
agg23 added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
agg23 added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Test results for "tests 1"

1 failed
❌ [webkit-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18

17 flaky ⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1175:1 › should update highlight when typing snapshot @chromium-ubuntu-22.04-node20
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [chromium-library] › tests/library/chromium/oopif.spec.ts:284:3 › should click @ubuntu-20.04-chromium-tip-of-tree
⚠️ [webkit-library] › tests/library/popup.spec.ts💯3 › should inherit touch support from browser context @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/popup.spec.ts:129:3 › should use viewport size from window features @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:278:14 › element screenshot › should restore viewport after page screenshot and exception @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:291:14 › element screenshot › should restore viewport after page screenshot and timeout @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:508:5 › selector generator › should generate exact title when necessary @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1704:1 › should toggle theme color @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:411:5 › screencast › should capture css transformation @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:868:5 › page screenshot animations › should wait for fonts to load @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37750 passed, 655 skipped
✔️✔️✔️

Merge workflow run.

agg23 added a commit that referenced this pull request Feb 3, 2025
agg23 added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
agg23 added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants