Revert "chore(docs): clarify connection method via BrowserType.connect (#34560)"#34594
Merged
mxschmitt merged 1 commit intomicrosoft:mainfrom Feb 3, 2025
Conversation
microsoft#34560)" This reverts commit 1936cfa.
agg23
approved these changes
Feb 3, 2025
mxschmitt
added a commit
that referenced
this pull request
Feb 3, 2025
…ia BrowserType.connect (#34560)"
agg23
added a commit
to agg23/playwright
that referenced
this pull request
Feb 3, 2025
…e.connect (microsoft#34560)" (microsoft#34594)" This reverts commit 3d5f85d.
agg23
added a commit
to agg23/playwright
that referenced
this pull request
Feb 3, 2025
…e.connect (microsoft#34560)" (microsoft#34594)" This reverts commit 3d5f85d.
Contributor
Test results for "tests 1"1 failed 17 flaky37750 passed, 655 skipped Merge workflow run. |
agg23
added a commit
that referenced
this pull request
Feb 3, 2025
agg23
added a commit
to agg23/playwright
that referenced
this pull request
Feb 3, 2025
agg23
added a commit
to agg23/playwright
that referenced
this pull request
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 1936cfa. It broke language ports (Python) which then saw the connect method without any other params on it.