feat(recorder): display primary page URL in recorder title#34637
Merged
agg23 merged 2 commits intomicrosoft:mainfrom Feb 7, 2025
Merged
feat(recorder): display primary page URL in recorder title#34637agg23 merged 2 commits intomicrosoft:mainfrom
agg23 merged 2 commits intomicrosoft:mainfrom
Conversation
agg23
commented
Feb 5, 2025
|
|
||
| import { test, expect } from './inspectorTest'; | ||
|
|
||
| test('should reflect formatted URL of the page', async ({ openRecorder, server }) => { |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if a new file is the best place for these tests. It seemed like there aren't any tests of the actual Recorder UI itself, only of specific code gen functionality.
This comment has been minimized.
This comment has been minimized.
pavelfeldman
reviewed
Feb 5, 2025
| window.playwrightSetSources = React.useCallback((sources: Source[]) => { | ||
| setSources(sources); | ||
| window.playwrightSourcesEchoForTest = sources; | ||
| React.useLayoutEffect(() => { |
Contributor
Author
There was a problem hiding this comment.
This is the way these side effects are supposed to be triggered in React (though ideally it would be useEffect, but I figured people would complain about it potentially being delayed too long). Prior to this change, they were being set on each render of the main component (which happens quite often since it receives the data from the bridge). Unnecessarily inefficient, and for no gain.
mxschmitt
reviewed
Feb 6, 2025
agg23
force-pushed
the
recorder-url-title
branch
from
dd8797c to
2c707de
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pavelfeldman
approved these changes
Feb 7, 2025
Member
|
One of the new tests is failing across all platforms: |
Contributor
Test results for "tests 1"1 failed 11 flaky37822 passed, 655 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34549. It is difficult to identify what recorder instance corresponds to a given browser session. This updates our title to roughly match how Chrome DevTools displays in the same scenario.
Note a given
BrowserContextcan have multiple pages, and thus multiple URLs. We take and maintain the first one (so your first tab) as the source of this URL.