Skip to content

chore: remove dead code#34651

Merged
Skn0tt merged 2 commits intomicrosoft:mainfrom
Skn0tt:git-commit-
Feb 6, 2025
Merged

chore: remove dead code#34651
Skn0tt merged 2 commits intomicrosoft:mainfrom
Skn0tt:git-commit-

Conversation

@Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Feb 6, 2025

Going by the code, there's no way that revision.timestamp is ever a Date. Let's remove the branch.

@Skn0tt Skn0tt requested review from Copilot and mxschmitt February 6, 2025 09:58
@Skn0tt Skn0tt self-assigned this Feb 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@Skn0tt Skn0tt merged commit 1c7436e into microsoft:main Feb 6, 2025
29 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Test results for "tests 1"

10 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-macos-latest
⚠️ [chromium-library] › tests/library/popup.spec.ts:264:3 › should not throw when click closes popup @ubuntu-20.04-chromium-tip-of-tree
⚠️ [webkit-library] › tests/library/browsercontext-reuse.spec.ts:86:1 › should reset serviceworker that hangs in importScripts @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:106:5 › selector generator › should not escape text with >> @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1551:1 › should not leak recorders @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:364:5 › page screenshot › path option should work @webkit-ubuntu-22.04-node18

37801 passed, 655 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants