Skip to content

Conversation

@alscotty
Copy link
Contributor

@alscotty alscotty commented Mar 18, 2025

Closes #35213

Adds a new button on hover that copies snapshot url to clipboard
(#35213)
And adds a test for the same
Screen Shot 2025-03-18 at 10 48 40 AM

@alscotty
Copy link
Contributor Author

@microsoft-github-policy-service agree

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@alscotty
Copy link
Contributor Author

@dgozman could you review this one when possible? Thanks!

Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@alscotty
Copy link
Contributor Author

Thanks for reviewing @dgozman ! Made those suggested changes and retested

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alscotty Thank you, this is very good! However, when I hover over the address bar, it gets wider now. Also, the button is not vertically aligned with the url text. Could you please fix both of these issues?

@alscotty
Copy link
Contributor Author

@alscotty Thank you, this is very good! However, when I hover over the address bar, it gets wider now. Also, the button is not vertically aligned with the url text. Could you please fix both of these issues?

Fixed using visibility instead of display, thanks! @dgozman

@alscotty
Copy link
Contributor Author

alscotty commented Mar 25, 2025

Screen Shot 2025-03-25 at 9 18 04 AM

Checking failure - seen on main branch also - not caused by this diff

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@mxschmitt mxschmitt merged commit cb7f112 into microsoft:main Mar 28, 2025
28 of 29 checks passed
@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › tests/runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1

3 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1306:1 › should pick locator in iframe @webkit-ubuntu-22.04-node18

38935 passed, 805 skipped
✔️✔️✔️

Merge workflow run.

@alscotty alscotty deleted the copy_trace_url_to_clipboard branch April 4, 2025 04:54
whazor pushed a commit to whazor/playwright-trace-viewer-plus that referenced this pull request Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add 'Copy url to clipboard' button to trace viewer

3 participants