-
Notifications
You must be signed in to change notification settings - Fork 5k
feat(trace-viewer): add copy to clipboard button for traceviewer snapshot url on hover (#35213) #35255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(trace-viewer): add copy to clipboard button for traceviewer snapshot url on hover (#35213) #35255
Conversation
|
@microsoft-github-policy-service agree |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@dgozman could you review this one when possible? Thanks! |
dgozman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
|
Thanks for reviewing @dgozman ! Made those suggested changes and retested |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alscotty Thank you, this is very good! However, when I hover over the address bar, it gets wider now. Also, the button is not vertically aligned with the url text. Could you please fix both of these issues?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"1 failed 3 flaky38935 passed, 805 skipped Merge workflow run. |
…over (microsoft#35213) (microsoft#35255) Co-authored-by: Max Schmitt <max@schmitt.mx>

Closes #35213
Adds a new button on hover that copies snapshot url to clipboard

(#35213)
And adds a test for the same