feat(trace-viewer): Move copy request buttons to toolbar #35366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Failing test seems flaky to me? |
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"1 failed 2 flaky38936 passed, 805 skipped Merge workflow run. |
Contributor
Author
|
Again, failed test seems flaky |
Skn0tt
reviewed
Mar 31, 2025
Member
Skn0tt
left a comment
Skn0tt
left a comment
There was a problem hiding this comment.
Change looks good! Left one small comment.
Skn0tt
approved these changes
Mar 31, 2025
dgozman
approved these changes
Mar 31, 2025
Contributor
dgozman
left a comment
dgozman
left a comment
There was a problem hiding this comment.
Looks good, merging in. Thank you for the PR!
Contributor
Test results for "tests 1"2 flaky38937 passed, 805 skipped Merge workflow run. |
whazor
pushed a commit
to whazor/playwright-trace-viewer-plus
that referenced
this pull request
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the copy request buttons to a dropdown on the toolbar:
Says 'copied' when option is pressed
references: #35214