Skip to content

Conversation

@yury-s
Copy link
Member

@yury-s yury-s commented Apr 10, 2025

Fixes #35562

@yury-s
Copy link
Member Author

yury-s commented Apr 10, 2025

Note that it changes the error message of expect(1).toBe(() => {}); from

Expected: [Function anonymous]

to

Error: () => {} could not be cloned.

We do need to throw on serialization errors, but I'm not sure if we want to do the switch to structured clone.

@yury-s yury-s requested review from dgozman and mxschmitt April 10, 2025 00:51
@github-actions

This comment has been minimized.

Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer our IPC to be pure json. Are these the expected/actual values? Perhaps we can apply our utility script serializer to them?

@yury-s
Copy link
Member Author

yury-s commented Apr 10, 2025

Are these the expected/actual values?

In this case yes. It's the actual value (probably formatted by expect matcher).

@yury-s yury-s changed the title fix: user structured clone for test runner IPC fix: do not pass unsafe matcherResult over IPC Apr 10, 2025
@yury-s yury-s requested a review from dgozman April 10, 2025 19:41
@github-actions

This comment has been minimized.

@yury-s yury-s merged commit adfad84 into microsoft:main Apr 10, 2025
29 checks passed
@yury-s yury-s deleted the ipc-structured-clone branch April 10, 2025 21:39
@github-actions
Copy link
Contributor

Test results for "tests 1"

4 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [chromium] › headerView.spec.tsx:46:1 › should toggle filters @web-components-html-reporter
⚠️ [webkit-page] › page/elementhandle-bounding-box.spec.ts:22:3 › should work @webkit-ubuntu-22.04-node18

39131 passed, 806 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Failing assertions containing BigInts cause infinite looping

2 participants