Skip to content

Conversation

@dgozman
Copy link
Contributor

@dgozman dgozman commented Apr 10, 2025

Also update page-click.spec.ts to not rely on javascript: urls that are processed in a separate task and could be deferred as well.

This was supposedly fixed upstream, see https://issues.chromium.org/u/1/issues/350540984.

References #34377.

@github-actions
Copy link
Contributor

Test results for "tests 1"

4 failed
❌ [chromium-page] › page/page-click.spec.ts:925:3 › should climb up to a anchor @chromium-ubuntu-22.04-node18
❌ [chromium-page] › page/page-click.spec.ts:925:3 › should climb up to a anchor @chromium-ubuntu-22.04-node20
❌ [chromium-page] › page/page-click.spec.ts:925:3 › should climb up to a anchor @chromium-ubuntu-22.04-node22
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:97:5 › should format JSON request body @macos-latest-node18-1

6 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-ct.spec.ts:117:5 › should run component tests after editing test and component @macos-latest-node18-1
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:115:5 › should print load/save storage_state @ubuntu-22.04-chromium-tip-of-tree
⚠️ [chromium-page] › page/page-click.spec.ts:925:3 › should climb up to a anchor @ubuntu-22.04-chromium-tip-of-tree
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39106 passed, 807 skipped
✔️✔️✔️

Merge workflow run.

…atures

Also update `page-click.spec.ts` to not rely on `javascript:` urls that
are processed in a separate task and could be deferred as well.
@dgozman dgozman force-pushed the chore-remove-defer-2 branch from 73483b7 to 190c914 Compare April 22, 2025 12:28
@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:99:5 › should format JSON request body @macos-latest-node18-1

4 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node18-1
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39046 passed, 799 skipped
✔️✔️✔️

Merge workflow run.

@pavelfeldman
Copy link
Member

what's up with all these failures?

@dgozman dgozman merged commit 108419a into microsoft:main Apr 23, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants