-
Notifications
You must be signed in to change notification settings - Fork 4.9k
chore(reporter): normalize reporter option types #35641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test results for "tests 1"7 flaky39028 passed, 924 skipped Merge workflow run. |
|
Looks a bit backwards to me. The new way is harder to read due to indirection. I can understand inheriting from the common base, but not parametrized templates for the sake of the struct props reuse. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ormalize-reporter-option-types
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"5 failed 8 flaky39100 passed, 803 skipped Merge workflow run. |
Remove type duplication in reporter option configuration.