Skip to content

Conversation

@agg23
Copy link
Contributor

@agg23 agg23 commented Apr 16, 2025

Remove type duplication in reporter option configuration.

@agg23 agg23 requested a review from dgozman April 16, 2025 19:50
@github-actions
Copy link
Contributor

Test results for "tests 1"

7 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-device.spec.ts:45:5 › device › should scroll to click @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:44:14 › page screenshot › should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:55:14 › page screenshot › should work with a mobile viewport and clip @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:66:14 › page screenshot › should work with a mobile viewport and fullPage @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18

39028 passed, 924 skipped
✔️✔️✔️

Merge workflow run.

@pavelfeldman
Copy link
Member

Looks a bit backwards to me. The new way is harder to read due to indirection. I can understand inheriting from the common base, but not parametrized templates for the sake of the struct props reuse.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Test results for "tests 1"

5 failed
❌ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
❌ [playwright-test] › playwright.artifacts.spec.ts:219:5 › should work with screenshot: only-on-failure & fullPage @macos-latest-node18-1
❌ [default-trace] › trace-viewer.spec.ts:83:5 › should refresh trace viewer while test is running @vscode-extension
❌ [webkit-library] › library/emulation-focus.spec.ts:104:3 › should not affect screenshots @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18

8 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:44:14 › page screenshot › should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:77:14 › page screenshot › should work with device scale factor @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:104:14 › page screenshot › should work with device scale factor, clip and scale:css @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/video.spec.ts:411:5 › screencast › should capture css transformation @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39100 passed, 803 skipped
✔️✔️✔️

Merge workflow run.

@agg23 agg23 merged commit 2dee419 into microsoft:main Apr 30, 2025
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants