Skip to content

chore: two-line trace view (4) #36070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pavelfeldman merged 1 commit into from
May 23, 2025
Merged

chore: two-line trace view (4) #36070

pavelfeldman merged 1 commit into from
May 23, 2025

Conversation

@pavelfeldman
Copy link
Member

@pavelfeldman pavelfeldman commented May 23, 2025 •
edited by mxschmitt
Loading

localhost_9323_trace_index html_trace=http___localhost_9323_data_d5f62275a1767ba338ba8cfec0922760094b3818 zip (1)

yury-s
yury-s approved these changes May 23, 2025
View reviewed changes
packages/playwright/src/matchers/expect.ts
category: (matcherName === 'toPass' || this._info.poll) ? 'step' : 'expect',
category: (matcherName === 'toPass' || this._info.poll) ? 'test.step' : 'expect' as TestStepCategory,
apiName,
title: trimLongString(title, 1024),
Copy link
Member

@yury-s yury-s May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did it go away?

Copy link
Member Author

@pavelfeldman pavelfeldman May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a wrong place for it - it was lossy.

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2025

Test results for "tests 1"

3 failed
❌ [default] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot @vscode-extension
❌ [default-trace] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot @vscode-extension

4 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-device.spec.ts:45:5 › device › should scroll to click @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39218 passed, 804 skipped
✔️✔️✔️

Merge workflow run.

@pavelfeldman pavelfeldman merged commit 9a53dc2 into microsoft:main May 23, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yury-s yury-s yury-s approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelfeldman @yury-s