-
Notifications
You must be signed in to change notification settings - Fork 4.9k
test: fix webview2 tests #36172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix webview2 tests #36172
Conversation
Test results for "tests others"3 flaky22033 passed, 523 skipped Merge workflow run. |
Test results for "tests 1"7 flaky39277 passed, 818 skipped Merge workflow run. |
Test results for "tests 2"5 fatal errors, not part of any test 151 flaky237009 passed, 9475 skipped, 3007 did not run Merge workflow run. |
Looks like #21220 is not always working and we see this over and over again.
The actual fix is the
waitForURL. The other two changes (error handling + updating the package are for good measure).