Skip to content

chore(bidi): add support for the input.fileDialogOpened event#38224

Merged
yury-s merged 1 commit intomicrosoft:mainfrom
hbenl:filedialogopened
Nov 17, 2025
Merged

chore(bidi): add support for the input.fileDialogOpened event#38224
yury-s merged 1 commit intomicrosoft:mainfrom
hbenl:filedialogopened

Conversation

@hbenl
Copy link
Collaborator

@hbenl hbenl commented Nov 14, 2025

Fixes the following tests in Firefox:

  • tests/library/capabilities.spec.ts:
    • "should not crash when clicking a label with a "
  • tests/page/page-filechooser.spec.ts:
    • "should upload multiple large files"
    • "should emit event once"
    • "should emit event via prepend"
    • "should emit event on/off"
    • "should emit event addListener/removeListener"
    • "should work when file input is attached to DOM"
    • "should work when file input is not attached to DOM"
    • "should not throw when filechooser belongs to iframe"
    • "should work with no timeout"
    • "should return the same file chooser when there are many watchdogs simultaneously"
    • "should accept single file"
    • "should be able to read selected file"
    • "should work for single file pick"
    • "should work for "multiple""
    • "should work for "webkitdirectory""
    • "should emit event after navigation"
    • "should trigger listener added before navigation"

@hbenl hbenl requested a review from yury-s November 14, 2025 14:42
@github-actions
Copy link
Contributor

Test results for "MCP"

2432 passed, 116 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › reporter.spec.ts:251 › merged › should not have internal error when steps are finished after timeout @macos-latest-node18-2

1 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`

40313 passed, 787 skipped


Merge workflow run.

@yury-s yury-s merged commit a764706 into microsoft:main Nov 17, 2025
33 of 36 checks passed
jchip pushed a commit to jchip/playwright that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants