-
Notifications
You must be signed in to change notification settings - Fork 4.9k
chore: perform-specific tools #38462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dede985 to
cd683b1
Compare
This comment has been minimized.
This comment has been minimized.
cd683b1 to
b5b0d86
Compare
This comment has been minimized.
This comment has been minimized.
b5b0d86 to
d65699d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tests/page/perform-task.spec.ts
Outdated
|
|
||
| test.skip('perform task', async ({ page }) => { | ||
| test('perform task', async ({ page }) => { | ||
| // TODO: need a local site for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use tests/assets/evals/fill-form.html. Take a look at browser.eval.ts for the task.
| ### Task | ||
| ${options.task} | ||
| `; | ||
| const { actions } = await perform(progress, page, task, resultSchema, options); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am somewhat worried that resultSchema is pretty complex, but hopefully it's ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm reverting this bit, will list actions from the backend instead.
d65699d to
f58306b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f58306b to
788491e
Compare
Test results for "MCP"2688 passed, 116 skipped Merge workflow run. |
Test results for "tests 1"4 flaky40287 passed, 795 skipped Merge workflow run. |
No description provided.