chore(line): report pause #38717

Skn0tt · 2026-01-08T12:29:55Z

No description provided.

packages/playwright/src/program.ts

dgozman · 2026-01-12T14:43:16Z

packages/playwright/src/reporters/line.ts

+          this.screen.stdout.write(`\u001B[1A\u001B[2K`);
+        }
+        this.writeLine();
+        for (const error of formatResultFailure(this.screen, test, { ...result, errors: newErrors }, '    '))


I don't understand why this.epilogue() won't print all the errors anyway.

(just an idea) we can mark errors with some symbol to avoid double-printing them.

we're passing false to this.epilogue(), so it doesn't print any errors at all. All errors are printed during onTestEnd.

dgozman · 2026-01-12T14:45:37Z

packages/playwright/src/reporters/line.ts

+    this._printedErrorCounts.set(result, result.errors.length);
+
+    if (result.errors.length > 0) {
+      const errorHeader = this.formatTestHeader(test, { indent: '  ', index: ++this._failures });


I think we can use a helper in base.ts, something like formatSingleResult(), that will include everything except for Paused .... Press Ctrl+C to end line.

Co-authored-by: Dmitry Gozman <dgozman@gmail.com> Signed-off-by: Simon Knott <info@simonknott.de>

dgozman · 2026-01-14T10:12:08Z

packages/playwright/src/common/config.ts

      updateSourceMethod: takeFirst(configCLIOverrides.updateSourceMethod, userConfig.updateSourceMethod, 'patch'),
      version: require('../../package.json').version,
-      workers: resolveWorkers(takeFirst(configCLIOverrides.debug ? 1 : undefined, configCLIOverrides.workers, userConfig.workers, '50%')),
+      workers: resolveWorkers(takeFirst((configCLIOverrides.debug || configCLIOverrides.pause) ? 1 : undefined, configCLIOverrides.workers, userConfig.workers, '50%')),


Given that debug implies pause, we can just check for pause here?

dgozman · 2026-01-14T11:29:35Z

packages/playwright/src/reporters/line.ts

  private _failures = 0;
  private _lastTest: TestCase | undefined;
  private _didBegin = false;
+  private _printedErrorCounts = new Map<TestResult, number>();


Remove this one.

dgozman · 2026-01-14T11:30:44Z

packages/playwright/src/reporters/base.ts

  }

-  for (const error of result.errors) {
+  const reportedIndex = (result as any)[kReportedSymbol] || 0;


Let's make this an explicit call, something like markErrorsAsReported(result), to avoid surprises in the future.

github-actions · 2026-01-14T12:50:55Z

Test results for "tests 1"

7 failed
❌ [default] › debug-tests.spec.ts:380 › should run global setup before debugging @vscode-extension
❌ [default] › debug-tests.spec.ts:516 › should not pause at the end of a setup test @vscode-extension
❌ [default-reuse] › debug-tests.spec.ts:380 › should run global setup before debugging @vscode-extension
❌ [default-reuse] › debug-tests.spec.ts:516 › should not pause at the end of a setup test @vscode-extension
❌ [default-trace] › debug-tests.spec.ts:380 › should run global setup before debugging @vscode-extension
❌ [default-trace] › debug-tests.spec.ts:516 › should not pause at the end of a setup test @vscode-extension
❌ [playwright-test] › runner.spec.ts:124 › should ignore subprocess creation error because of SIGINT @macos-latest-node20

4 flaky

⚠️ [chromium-library] › library/popup.spec.ts:258 › should not throw when click closes popup `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:426 › should work behind reverse proxy `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:688 › should indicate current test status `@macos-latest-node20`

34458 passed, 699 skipped

Merge workflow run.

github-actions · 2026-01-14T12:56:01Z

Test results for "MCP"

1 failed
❌ [chrome] › mcp/autowait.spec.ts:19 › racy navigation destroys context @mcp-windows-latest

2821 passed, 116 skipped

Merge workflow run.

chore(line): report pause

41a9e51

Skn0tt requested a review from dgozman January 8, 2026 12:29