Skip to content

Fix(tests) #35113 Fix toHaveCSS tests to pass across platforms#38787

Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom
iumehara:35113-fix-tests
Jan 19, 2026
Merged

Fix(tests) #35113 Fix toHaveCSS tests to pass across platforms#38787
pavelfeldman merged 1 commit intomicrosoft:mainfrom
iumehara:35113-fix-tests

Conversation

@iumehara
Copy link
Copy Markdown
Contributor

  • Fix tests to pass across Chromium, Safari, Firefox.
  • Avoid values that are inconsistent on mobile (ie. '1px')

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests 1"

9 failed
❌ [default] › debug-tests.spec.ts:380 › should run global setup before debugging @vscode-extension
❌ [default] › debug-tests.spec.ts:516 › should not pause at the end of a setup test @vscode-extension
❌ [default-reuse] › debug-tests.spec.ts:380 › should run global setup before debugging @vscode-extension
❌ [default-reuse] › debug-tests.spec.ts:516 › should not pause at the end of a setup test @vscode-extension
❌ [default-reuse] › watch.spec.ts:422 › should batch watched tests, not queue @vscode-extension
❌ [default-trace] › debug-tests.spec.ts:380 › should run global setup before debugging @vscode-extension
❌ [default-trace] › debug-tests.spec.ts:516 › should not pause at the end of a setup test @vscode-extension
❌ [firefox-library] › library/browsertype-launch.spec.ts:64 › should reject if launched browser fails immediately @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/launcher.spec.ts:44 › should throw a friendly error if its headed and there is no xserver on linux running @firefox-ubuntu-22.04-node20

4 flaky ⚠️ [chromium-library] › library/popup.spec.ts:258 › should not throw when click closes popup `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › runner.spec.ts:124 › should ignore subprocess creation error because of SIGINT `@macos-latest-node20`

34480 passed, 699 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "MCP"

2830 passed, 121 skipped


Merge workflow run.

@iumehara
Copy link
Copy Markdown
Contributor Author

HI @Skn0tt, can you confirm if this is good to go? I see some failing tests, but they don't seem seem to be related to this code change from what I can tell. Just want to confirm we're not waiting on a change from my end.

@pavelfeldman pavelfeldman merged commit 99d146e into microsoft:main Jan 19, 2026
29 of 32 checks passed
@iumehara iumehara deleted the 35113-fix-tests branch January 19, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants