Skip to content

Conversation

@hbenl
Copy link
Collaborator

@hbenl hbenl commented Jan 15, 2026

BiDi doesn't allow to set permissions for all origins, so those permissions are stored and then applied to all existing frame origins and whenever a frame is created or navigated.

Fixes the following tests:

  • library/defaultbrowsercontext-2.spec.ts:
    • "should support geolocation and permissions options"
  • library/geolocation.spec.ts:
    • "should isolate contexts"
    • "should use context options"
    • "should use context options for popup"
    • "should work"
    • "watchPosition should be notified"
  • library/permissions.spec.ts:
    • "permissions > should accumulate when adding"
    • "permissions > should clear permissions"
    • "permissions > should grant permission when creating context"
    • "permissions > should grant permission when listed for all domains"

@github-actions
Copy link
Contributor

Test results for "MCP"

2830 passed, 121 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 1"

4 failed
❌ [firefox-library] › library/browsertype-launch.spec.ts:64 › should reject if launched browser fails immediately @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/launcher.spec.ts:44 › should throw a friendly error if its headed and there is no xserver on linux running @firefox-ubuntu-22.04-node20
❌ [playwright-test] › reporter-html.spec.ts:1037 › merged › should have link for opening HTML attachments in new tab @macos-latest-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:345 › should update multiple files @windows-latest-node20

4 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:297 › should detect mime type `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:183 › should show snapshots for steps `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:796 › should update state on subsequent run `@macos-latest-node20`

34491 passed, 693 skipped


Merge workflow run.

@Skn0tt Skn0tt merged commit 327bd18 into microsoft:main Jan 15, 2026
29 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants