feat(api): add Request.existingResponse() method #39077
Merged
+74
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a synchronous method to get the response object if it has already been received, without waiting. Returns null if the response hasn't arrived yet.
pavelfeldman
reviewed
Feb 1, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yury-s
force-pushed
the
add-request-existing-response-api
branch
from
72f3b01 to
e887e0b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "MCP"1 failed 3819 passed, 145 skipped Merge workflow run. |
pavelfeldman
reviewed
Feb 2, 2026
| this._browserContextDispatcher = scope; | ||
| this.addObjectListener(Request.Events.Response, () => this._dispatchEvent('response', {})); | ||
| // Push existing response to the client if it exists. | ||
| ResponseDispatcher.fromNullable(scope, request._existingResponse()); |
Member
There was a problem hiding this comment.
This will create a state where for a request with the response on the server side, response-less request will be created on the client.
Member
There was a problem hiding this comment.
Sounds like hasResponse is the only way to make it work w/o fixing channels.
pavelfeldman
approved these changes
Feb 2, 2026
Contributor
Test results for "tests 1"2 failed 5 flaky34270 passed, 662 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a synchronous method to get the response object if it has already been received, without waiting. Returns null if the response hasn't arrived yet.