chore(cli): do not pick legacy sessions, list all sessions#39146
Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom Feb 5, 2026
Merged
chore(cli): do not pick legacy sessions, list all sessions#39146pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman merged 1 commit intomicrosoft:mainfrom
Conversation
pavelfeldman
force-pushed
the
legacy_fix
branch
from
34ae174 to
c186bea
Compare
pavelfeldman
changed the title
Contributor
Test results for "MCP"40 failed @mcp-ubuntu-latest❌ [chromium] › mcp/cli-isolated.spec.ts:21 › should not save user data by default (in-memory mode) @mcp-ubuntu-latest❌ [chromium] › mcp/cli-isolated.spec.ts:38 › should save user data with --persistent flag @mcp-ubuntu-latest❌ [chromium] › mcp/cli-isolated.spec.ts:53 › should use custom user data dir with --profile= @mcp-ubuntu-latest❌ [firefox] › mcp/cli-isolated.spec.ts:21 › should not save user data by default (in-memory mode) @mcp-ubuntu-latest❌ [firefox] › mcp/cli-isolated.spec.ts:38 › should save user data with --persistent flag @mcp-ubuntu-latest❌ [firefox] › mcp/cli-isolated.spec.ts:53 › should use custom user data dir with --profile= @mcp-ubuntu-latest❌ [webkit] › mcp/cli-isolated.spec.ts:21 › should not save user data by default (in-memory mode) @mcp-ubuntu-latest❌ [webkit] › mcp/cli-isolated.spec.ts:38 › should save user data with --persistent flag @mcp-ubuntu-latest❌ [webkit] › mcp/cli-isolated.spec.ts:53 › should use custom user data dir with --profile= @mcp-ubuntu-latest❌ [chrome] › mcp/cli-isolated.spec.ts:21 › should not save user data by default (in-memory mode) @mcp-windows-latest❌ [chrome] › mcp/cli-isolated.spec.ts:38 › should save user data with --persistent flag @mcp-windows-latest❌ [chrome] › mcp/cli-isolated.spec.ts:53 › should use custom user data dir with --profile= @mcp-windows-latest❌ [chromium] › mcp/cli-isolated.spec.ts:21 › should not save user data by default (in-memory mode) @mcp-windows-latest❌ [chromium] › mcp/cli-isolated.spec.ts:38 › should save user data with --persistent flag @mcp-windows-latest❌ [chromium] › mcp/cli-isolated.spec.ts:53 › should use custom user data dir with --profile= @mcp-windows-latest❌ [firefox] › mcp/cli-isolated.spec.ts:21 › should not save user data by default (in-memory mode) @mcp-windows-latest❌ [firefox] › mcp/cli-isolated.spec.ts:38 › should save user data with --persistent flag @mcp-windows-latest❌ [firefox] › mcp/cli-isolated.spec.ts:53 › should use custom user data dir with --profile= @mcp-windows-latest❌ [webkit] › mcp/cli-isolated.spec.ts:21 › should not save user data by default (in-memory mode) @mcp-windows-latest❌ [webkit] › mcp/cli-isolated.spec.ts:38 › should save user data with --persistent flag @mcp-windows-latest❌ [webkit] › mcp/cli-isolated.spec.ts:53 › should use custom user data dir with --profile= @mcp-windows-latest❌ [msedge] › mcp/cli-isolated.spec.ts:21 › should not save user data by default (in-memory mode) @mcp-windows-latest❌ [msedge] › mcp/cli-isolated.spec.ts:38 › should save user data with --persistent flag @mcp-windows-latest❌ [msedge] › mcp/cli-isolated.spec.ts:53 › should use custom user data dir with --profile= @mcp-windows-latest❌ [chrome] › mcp/cli-isolated.spec.ts:21 › should not save user data by default (in-memory mode) @mcp-macos-15❌ [chrome] › mcp/cli-isolated.spec.ts:38 › should save user data with --persistent flag @mcp-macos-15❌ [chrome] › mcp/cli-isolated.spec.ts:53 › should use custom user data dir with --profile= @mcp-macos-15❌ [chromium] › mcp/cli-isolated.spec.ts:21 › should not save user data by default (in-memory mode) @mcp-macos-15❌ [chromium] › mcp/cli-isolated.spec.ts:38 › should save user data with --persistent flag @mcp-macos-15❌ [chromium] › mcp/cli-isolated.spec.ts:53 › should use custom user data dir with --profile= @mcp-macos-15❌ [chromium] › mcp/config.spec.ts:23 › config user data dir @mcp-macos-15❌ [firefox] › mcp/cli-isolated.spec.ts:21 › should not save user data by default (in-memory mode) @mcp-macos-15❌ [firefox] › mcp/cli-isolated.spec.ts:38 › should save user data with --persistent flag @mcp-macos-15❌ [firefox] › mcp/cli-isolated.spec.ts:53 › should use custom user data dir with --profile= @mcp-macos-15❌ [webkit] › mcp/cli-isolated.spec.ts:21 › should not save user data by default (in-memory mode) @mcp-macos-15❌ [webkit] › mcp/cli-isolated.spec.ts:38 › should save user data with --persistent flag @mcp-macos-15❌ [webkit] › mcp/cli-isolated.spec.ts:53 › should use custom user data dir with --profile= @mcp-macos-15
4622 passed, 135 skipped Merge workflow run. |
dgozman
approved these changes
Feb 5, 2026
|
|
||
| for (const workspace of sortedWorkspaces) { | ||
| const sessions = sessionsByWorkspace.get(workspace)!; | ||
| // Only print workspace folder if it's set |
| if (!canConnect) { | ||
| console.log(` ${name} (stale)`); | ||
| } else { | ||
| const restartMarker = !isCompatible ? ` - v${config.version}, please reopen` : ''; |
Contributor
There was a problem hiding this comment.
I am not sure we should suggest please reopen when listing all sessions. It is probably working fine with some other client.
Member
Author
There was a problem hiding this comment.
client is always global - cant be another client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.