Skip to content

chore(cli): implement direct daemon startup#39162

Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:proper_start_cli
Feb 6, 2026
Merged

chore(cli): implement direct daemon startup#39162
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:proper_start_cli

Conversation

@pavelfeldman
Copy link
Member

No description provided.

@pavelfeldman pavelfeldman force-pushed the proper_start_cli branch 4 times, most recently from 8c86c96 to a674183 Compare February 6, 2026 00:14
const child = spawn(process.execPath, args, {
detached: true,
stdio: ['ignore', out, err],
stdio: ['ignore', out, 'pipe'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when parent dies?

@pavelfeldman pavelfeldman merged commit e0e7f41 into microsoft:main Feb 6, 2026
29 of 32 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Test results for "tests 1"

2 failed
❌ [playwright-test] › playwright.ct-react.spec.ts:422 › should handle the baseUrl config @macos-latest-node20
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:301 › should copy network request @macos-latest-node20

6 flaky ⚠️ [chromium-library] › library/popup.spec.ts:258 › should not throw when click closes popup `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-page] › page/page-event-console.spec.ts:250 › should have timestamp in consoleMessages `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:754 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35 › should update locator highlight `@firefox-ubuntu-22.04-node20`

34222 passed, 756 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Test results for "MCP"

1 failed
❌ [chrome] › mcp/autowait.spec.ts:19 › racy navigation destroys context @mcp-windows-latest

4687 passed, 135 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants