fix(mcp): respect fs-based lock file for chromium family#39377
Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom Feb 24, 2026
Merged
fix(mcp): respect fs-based lock file for chromium family#39377pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman merged 1 commit intomicrosoft:mainfrom
Conversation
yury-s
approved these changes
Feb 24, 2026
| } | ||
|
|
||
| export function isProfileLocked(userDataDir: string): boolean { | ||
| const lockFile = process.platform === 'win32' ? 'lockfile' : 'SingletonLock'; |
Member
There was a problem hiding this comment.
why is the name different between platforms?
Member
Author
There was a problem hiding this comment.
I think Chrome folks decided to keep the pipe and the file names separate.
| const pid = parseInt(target.split('-').pop() || '', 10); | ||
| if (isNaN(pid)) | ||
| return false; | ||
| process.kill(pid, 0); |
Member
There was a problem hiding this comment.
what if it's a legit browser closure, just taking longer than usual?
Member
Author
There was a problem hiding this comment.
We kill(0) - probe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/playwright-mcp#1311