feat: retain-on-failure-and-retries trace option#39387
Merged
dgozman merged 3 commits intomicrosoft:mainfrom Mar 2, 2026
Merged
feat: retain-on-failure-and-retries trace option#39387dgozman merged 3 commits intomicrosoft:mainfrom
dgozman merged 3 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
yury-s
approved these changes
Feb 25, 2026
| expect(fs.existsSync(retryTracePath)).toBeTruthy(); | ||
| }); | ||
|
|
||
| test('trace:retain-on-failure-and-retries should not create trace if test passes', async ({ runInlineTest }, testInfo) => { |
Member
There was a problem hiding this comment.
remove this test, this case is already covered by test(trace:${mode} should not create trace zip artifact if page test passed above
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"5 flaky38683 passed, 841 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 5132 passed, 171 skipped Merge workflow run. |
dgozman
approved these changes
Mar 2, 2026
Collaborator
|
Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34588
Summary
Adds a new retain-on-failure-and-retries trace mode that records traces for every test attempt (initial run + retries) and retains all of them when any attempt fails. This makes it possible to compare failing and passing runs side-by-side when debugging flaky tests.
Behavior
Changes