Skip to content

test: gardening some tests failing on WebKit #39439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yury-s merged 1 commit into from
Feb 26, 2026
Merged

test: gardening some tests failing on WebKit #39439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/library/browsercontext-timezone-id.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,25 +24,25 @@ it('should work @smoke', async ({ browser, browserName }) => {
{
const context = await browser.newContext({ locale: 'en-US', timezoneId: 'America/Jamaica' });
const page = await context.newPage();
expect(await page.evaluate(func)).toContain('Sat Nov 19 2016 13:12:34 GMT-0500');
expect.soft(await page.evaluate(func)).toContain('Sat Nov 19 2016 13:12:34 GMT-0500');
await context.close();
}
{
const context = await browser.newContext({ locale: 'en-US', timezoneId: 'Pacific/Honolulu' });
const page = await context.newPage();
expect(await page.evaluate(func)).toContain('Sat Nov 19 2016 08:12:34 GMT-1000');
expect.soft(await page.evaluate(func)).toContain('Sat Nov 19 2016 08:12:34 GMT-1000');
await context.close();
}
{
const context = await browser.newContext({ locale: 'en-US', timezoneId: browserName === 'firefox' ? 'America/Argentina/Buenos_Aires' : 'America/Buenos_Aires' });
const page = await context.newPage();
expect(await page.evaluate(func)).toContain('Sat Nov 19 2016 15:12:34 GMT-0300');
expect.soft(await page.evaluate(func)).toContain('Sat Nov 19 2016 15:12:34 GMT-0300');
await context.close();
}
{
const context = await browser.newContext({ locale: 'en-US', timezoneId: 'Europe/Berlin' });
const page = await context.newPage();
expect(await page.evaluate(func)).toContain('Sat Nov 19 2016 19:12:34 GMT+0100');
expect.soft(await page.evaluate(func)).toContain('Sat Nov 19 2016 19:12:34 GMT+0100');
await context.close();
}
});
Expand Down
4 changes: 3 additions & 1 deletion tests/library/browsertype-connect.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,9 @@ for (const kind of ['launchServer', 'run-server'] as const) {
expect(request.headers['foo']).toBe('bar');
});

test('should send default User-Agent and X-Playwright-Browser headers with connect request', async ({ connect, browserName, server }) => {
test('should send default User-Agent and X-Playwright-Browser headers with connect request', async ({ connect, browserName, server, isMac, macVersion }) => {
test.skip(browserName === 'webkit' && isMac && macVersion <= 14, 'WebKit on macOS-14 is frozen');

const [request] = await Promise.all([
server.waitForWebSocketConnectionRequest(),
connect(`ws://localhost:${server.PORT}/ws`, {
Expand Down
4 changes: 3 additions & 1 deletion tests/library/popup.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
import { browserTest as it, expect } from '../config/browserTest';
import type { Page } from 'playwright-core';

it('should inherit user agent from browser context @smoke', async function({ browser, server }) {
it('should inherit user agent from browser context @smoke', async function({ browser, server, browserName, isMac, macVersion }) {
it.skip(browserName === 'webkit' && isMac && macVersion <= 14, 'WebKit on macOS-14 is frozen');

const context = await browser.newContext({
userAgent: 'hey'
});
Expand Down