chore(docker): add Finch build helper script#39451
Closed
claytonblythe wants to merge 1 commit into
Closed
Conversation
8f98d89 to
cb5a1da
Compare
Author
|
@microsoft-github-policy-service agree |
Member
|
This can live somewhere outside of this repository. We have build.sh only because it is used by our automation and we don't have one for Finch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
utils/docker/build_finch.shas a Finch equivalent ofutils/docker/build.shfor local contributor workflows.This script mirrors the existing Docker helper:
{--arm64,--amd64} {jammy,noble} <tag>pack_package.js->playwright-core.tar.gz)utils/docker/Dockerfile.jammy|noble)finch buildvsdocker build)Why
Some contributor environments use Finch instead of Docker CLI.
This helper provides a minimal, explicit path to build the same local Playwright image with Finch.
Scope / Non-goals
Validation (macOS arm64, Finch v1.15.1)
1) Script usage/help
$ ./utils/docker/build_finch.sh -h usage: build_finch.sh {--arm64,--amd64} {jammy,noble} playwright:localbuild-noble ...2) Noble build + runtime + Playwright docker marker
3) Jammy build + runtime + Playwright docker marker