Skip to content

Revert "fix(electron): pass port via switches not args"#39710

Merged
pavelfeldman merged 1 commit intomainfrom
revert-39012-electron-port-fix
Mar 16, 2026
Merged

Revert "fix(electron): pass port via switches not args"#39710
pavelfeldman merged 1 commit intomainfrom
revert-39012-electron-port-fix

Conversation

@pavelfeldman
Copy link
Member

Reverts #39012

We are actually getting 0 complaints about the behavior on 1.58, while we see it regress in new Electrons (VS Code that is using Electron 39 does not work with the new way).

@pavelfeldman pavelfeldman merged commit 5df6a4e into main Mar 16, 2026
35 of 37 checks passed
@pavelfeldman pavelfeldman deleted the revert-39012-electron-port-fix branch March 16, 2026 23:09
@github-actions
Copy link
Contributor

Test results for "MCP"

1 failed
❌ [chrome] › mcp/autowait.spec.ts:19 › racy navigation destroys context @mcp-windows-latest

5338 passed, 186 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 1"

9 failed
❌ [default] › run-tests.spec.ts:226 › should show error message @vscode-extension
❌ [default] › run-tests.spec.ts:278 › should show soft error messages @vscode-extension
❌ [default] › run-tests.spec.ts:818 › should report project-specific failures @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:226 › should show error message @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:278 › should show soft error messages @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:818 › should report project-specific failures @vscode-extension
❌ [default-trace] › run-tests.spec.ts:226 › should show error message @vscode-extension
❌ [default-trace] › run-tests.spec.ts:278 › should show soft error messages @vscode-extension
❌ [default-trace] › run-tests.spec.ts:818 › should report project-specific failures @vscode-extension

4 flaky ⚠️ [chromium-library] › library/video.spec.ts:358 › screencast › should capture navigation `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/popup.spec.ts:261 › should not throw when click closes popup `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@webkit-ubuntu-22.04-node20`

38763 passed, 847 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants