Skip to content

fix(api): make Page.screencast a property instead of a method#39711

Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:fix-screencast-property
Mar 17, 2026
Merged

fix(api): make Page.screencast a property instead of a method#39711
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:fix-screencast-property

Conversation

@pavelfeldman
Copy link
Member

Summary

  • Page.screencast was accidentally defined as a method; changed it to a readonly property, consistent with keyboard, mouse, touchscreen, etc.

@pavelfeldman pavelfeldman force-pushed the fix-screencast-property branch from 8009ce2 to 10e39e7 Compare March 16, 2026 23:32
Page.screencast was accidentally defined as a method. It should be a
readonly property, consistent with keyboard, mouse, touchscreen, etc.
@pavelfeldman pavelfeldman force-pushed the fix-screencast-property branch from 10e39e7 to 1e4645d Compare March 16, 2026 23:35
@github-actions
Copy link
Contributor

Test results for "MCP"

5339 passed, 186 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 1"

9 failed
❌ [default] › run-tests.spec.ts:226 › should show error message @vscode-extension
❌ [default] › run-tests.spec.ts:278 › should show soft error messages @vscode-extension
❌ [default] › run-tests.spec.ts:818 › should report project-specific failures @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:226 › should show error message @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:278 › should show soft error messages @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:818 › should report project-specific failures @vscode-extension
❌ [default-trace] › run-tests.spec.ts:226 › should show error message @vscode-extension
❌ [default-trace] › run-tests.spec.ts:278 › should show soft error messages @vscode-extension
❌ [default-trace] › run-tests.spec.ts:818 › should report project-specific failures @vscode-extension

5 flaky ⚠️ [chromium-library] › library/popup.spec.ts:261 › should not throw when click closes popup `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:700 › should indicate current test status `@macos-latest-node20`

38767 passed, 847 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants