Skip to content

test(network): remove flaky cached IMG waitForResponse test#39713

Merged
yury-s merged 1 commit intomicrosoft:mainfrom
yury-s:remove-cached-img-test
Mar 17, 2026
Merged

test(network): remove flaky cached IMG waitForResponse test#39713
yury-s merged 1 commit intomicrosoft:mainfrom
yury-s:remove-cached-img-test

Conversation

@yury-s
Copy link
Member

@yury-s yury-s commented Mar 17, 2026 •
edited
Loading

@yury-s
test(network): remove flaky cached IMG waitForResponse test
f09526d 
The test "should work with re-rendered cached IMG elements" relied on
Chromium emitting CDP Network events (requestWillBeSent /
responseReceived) when a recently-fetched image is re-inserted into the
DOM and served from memory cache. Newer Chromium versions no longer fire
these events for memory-cache hits (emitting requestServedFromCache
instead, or nothing at all), so waitForRequest/waitForResponse never
resolve and the test times out.
@yury-s yury-s merged commit e50a59c into microsoft:main Mar 17, 2026
36 of 37 checks passed
@yury-s yury-s deleted the remove-cached-img-test branch March 17, 2026 04:02
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2026

Test results for "MCP"

5339 passed, 186 skipped

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2026

Test results for "tests 1"

9 failed
❌ [default] › run-tests.spec.ts:226 › should show error message @vscode-extension
❌ [default] › run-tests.spec.ts:278 › should show soft error messages @vscode-extension
❌ [default] › run-tests.spec.ts:818 › should report project-specific failures @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:226 › should show error message @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:278 › should show soft error messages @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:818 › should report project-specific failures @vscode-extension
❌ [default-trace] › run-tests.spec.ts:226 › should show error message @vscode-extension
❌ [default-trace] › run-tests.spec.ts:278 › should show soft error messages @vscode-extension
❌ [default-trace] › run-tests.spec.ts:818 › should report project-specific failures @vscode-extension

5 flaky ⚠️ [chromium-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/video.spec.ts:358 › screencast › should capture navigation `@chromium-ubuntu-22.04-arm-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-test-output.spec.ts:118 › should collapse repeated console messages for test `@macos-latest-node20`

38762 passed, 845 skipped

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgozman dgozman dgozman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yury-s @dgozman