fix(api): make Tracing.group return Disposable#39729
Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom Mar 17, 2026
Merged
fix(api): make Tracing.group return Disposable#39729pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman merged 1 commit intomicrosoft:mainfrom
Conversation
dgozman
approved these changes
Mar 17, 2026
Tracing.group() now returns a Disposable that calls groupEnd() on dispose, enabling `await using` pattern for automatic group cleanup.
3fa79f9 to
e8afffd
Compare
Contributor
Test results for "MCP"2 failed 5337 passed, 186 skipped Merge workflow run. |
Contributor
Test results for "tests 1"1 failed 7 flaky38740 passed, 845 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracing.group()now returns aDisposablethat callsgroupEnd()on disposeawait usingpattern for automatic group cleanup