Skip to content

chore: deduplicate msToString and bytesToString into isomorphic/formatUtils#39770

Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:chore-dedup-format-utils
Mar 19, 2026
Merged

chore: deduplicate msToString and bytesToString into isomorphic/formatUtils#39770
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:chore-dedup-format-utils

Conversation

@pavelfeldman
Copy link
Member

Summary

  • Extract duplicated msToString and bytesToString formatting utilities into a single shared file at utils/isomorphic/formatUtils.ts
  • Remove 4 duplicate implementations from uiUtils.ts, traceCli.ts, utilsBundle.ts, and html-reporter/utils.ts
  • Update all consumers across trace-viewer, html-reporter, recorder, and reporters to import from the shared location

…tUtils

Move duplicated time/size formatting utilities into a single shared
location at utils/isomorphic/formatUtils.ts and update all consumers.
@pavelfeldman pavelfeldman force-pushed the chore-dedup-format-utils branch from 843a31b to 958f9fd Compare March 19, 2026 18:34
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Test results for "MCP"

1 failed
❌ [chrome] › mcp/cli-session.spec.ts:45 › close named session @mcp-macos-latest

5506 passed, 343 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › playwright.spec.ts:122 › should override any headless option with --headed @ubuntu-latest-node22

5 flaky ⚠️ [chromium-library] › library/popup.spec.ts:261 › should not throw when click closes popup `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@chromium-ubuntu-22.04-arm-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node20`

38815 passed, 845 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants