Skip to content

chore(cli): extract trace CLI command handlers into separate files#39771

Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:trace-cli-cli-dash
Mar 20, 2026
Merged

chore(cli): extract trace CLI command handlers into separate files#39771
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:trace-cli-cli-dash

Conversation

@pavelfeldman
Copy link
Copy Markdown
Member

Summary

  • Split the monolithic traceCli.ts into focused modules: traceUtils.ts, traceOpen.ts, traceActions.ts, traceRequests.ts, traceConsole.ts, traceErrors.ts, traceSnapshot.ts, traceScreenshot.ts, traceAttachments.ts, installSkill.ts
  • Introduced LoadedTrace class to encapsulate trace model, loader, and ordinal maps
  • Updated DEPS.list to allow local imports and declare snapshot-specific dependencies
  • Updated tests to use trace open + CWD-based workflow instead of passing trace file to every command
  • Replaced custom padEnd/padStart helpers with native String.prototype methods
  • Updated SKILL.md to reflect the open-first CLI workflow

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "MCP"

5494 passed, 343 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests 1"

11 flaky ⚠️ [chromium-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/screencast.spec.ts:23 › screencast.start delivers frames via onFrame callback `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:842 › run-server › socks proxy › should proxy localhost requests @smoke `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@webkit-ubuntu-22.04-node20`
⚠️ [webkit-page] › page/page-autowaiting-basic.spec.ts:58 › should await form-get on click `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:763 › should partition action tree state by test `@windows-latest-node20`

38810 passed, 845 skipped


Merge workflow run.

@pavelfeldman pavelfeldman merged commit b455769 into microsoft:main Mar 20, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants