fix(reporter): use Screen in html reporter for PLAYWRIGHT_FORCE_TTY support#39776
Open
yury-s wants to merge 3 commits intomicrosoft:mainfrom
Open
fix(reporter): use Screen in html reporter for PLAYWRIGHT_FORCE_TTY support#39776yury-s wants to merge 3 commits intomicrosoft:mainfrom
yury-s wants to merge 3 commits intomicrosoft:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
Looks dangerous as it will block users that opted into PLAYWRIGHT_FORCE_TTY for non-TTY CI as per our recommendation. |
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"6 flaky38815 passed, 845 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 5493 passed, 343 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process.stdin.isTTYchecks in the HTML reporter withterminalScreen.isTTY, which respects thePLAYWRIGHT_FORCE_TTYenvironment variableprocess.stdout.writeinwriteLinewithterminalScreen.stdout.writefor consistencyThis fixes the regression introduced in #38044 where JetBrains IDEs (WebStorm, IntelliJ) stopped auto-opening the HTML report because their test runners don't set
process.stdin.isTTY. Users can now setPLAYWRIGHT_FORCE_TTY=1to work around this.Fixes #39766