feat(annotate): instrument input actions and show subtitle overlay#39797
Merged
pavelfeldman merged 2 commits intomicrosoft:mainfrom Mar 22, 2026
Merged
feat(annotate): instrument input actions and show subtitle overlay#39797pavelfeldman merged 2 commits intomicrosoft:mainfrom
pavelfeldman merged 2 commits intomicrosoft:mainfrom
Conversation
pavelfeldman
force-pushed
the
annotate-input-actions
branch
from
8152196 to
589cb02
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Mar 21, 2026
| for (const entry of this._renderedEntries) { | ||
| entry.box = entry.targetElement.getBoundingClientRect(); | ||
| if (!entry.box && !entry.targetElement) | ||
| continue; |
Contributor
There was a problem hiding this comment.
I think we still want to update the tooltip in this case.
| const title = renderTitleForCall(metadata); | ||
| const utility = await page.mainFrame()._utilityContext(); | ||
|
|
||
| // Run this outside of the progress timer. |
Contributor
There was a problem hiding this comment.
Why? The progress timer is ticking anyway, so it still takes away from the action timeout.
Member
Author
There was a problem hiding this comment.
I never want this animation to interrupt, probably need to do something about progress there in general.
|
|
||
| async apiUp(progress: Progress, options: { button?: types.MouseButton, clickCount?: number } = {}) { | ||
| progress.metadata.point = this.currentPoint(); | ||
| await this._page.instrumentation.onBeforeInputAction(this._page, progress.metadata); |
Contributor
There was a problem hiding this comment.
It seems like we now capture the same tracing snapshot twice - on onBeforeCall and onBeforeInputAction immediately after it.
| const utility = await page.mainFrame()._utilityContext(); | ||
|
|
||
| // Run this outside of the progress timer. | ||
| await utility.evaluate(async options => { |
Contributor
There was a problem hiding this comment.
Let's catch this one, or even better - the whole method?
| const target = targetElements[0]; | ||
| const targetBox = target?.getBoundingClientRect(); | ||
| const targetCenter = target ? { x: targetBox.left + targetBox.width / 2, y: targetBox.top + targetBox.height / 2 } : null; | ||
| const isAligned = !targetCenter || Math.abs(targetCenter.x - pointX) > 10 || Math.abs(targetCenter.y - pointY) > 10; |
Contributor
There was a problem hiding this comment.
Suggested change
| const isAligned = !targetCenter || Math.abs(targetCenter.x - pointX) > 10 || Math.abs(targetCenter.y - pointY) > 10; | |
| const isAligned = !targetCenter || (Math.abs(targetCenter.x - pointX) < 10 && Math.abs(targetCenter.y - pointY) < 10); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pavelfeldman
force-pushed
the
annotate-input-actions
branch
from
589cb02 to
c9c52b2
Compare
Contributor
Test results for "tests 1"3 flaky38818 passed, 845 skipped Merge workflow run. |
Contributor
Test results for "MCP"5458 passed, 340 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onBeforeInputActioninstrumentation for raw keyboard/mouse/touchscreen viaapi*methodsmetadata.boxfrom element bounding rectpausesBeforeActiontopausesBeforeInput