fix(mcp): do not let empty cdpHeaders from env override config file#39866
Merged
dgozman merged 2 commits intomicrosoft:mainfrom Mar 27, 2026
Conversation
Contributor
Author
@microsoft-github-policy-service agree |
dgozman
reviewed
Mar 26, 2026
| contextOptions, | ||
| cdpEndpoint: cliOptions.cdpEndpoint, | ||
| cdpHeaders: cliOptions.cdpHeader, | ||
| cdpHeaders: nonEmptyRecord(cliOptions.cdpHeader), |
Collaborator
There was a problem hiding this comment.
It seems like a better solution could be replacing return previous || {}; with return previous; in the headerParser() function. Basically, returning undefined for the empty headers string. Then, usual logic with filtering undefined would just work. WDYT?
Contributor
Author
There was a problem hiding this comment.
I agree. I made the change.
Contributor
Test results for "MCP"5562 passed, 340 skipped Merge workflow run. |
dgozman
approved these changes
Mar 27, 2026
Collaborator
dgozman
left a comment
There was a problem hiding this comment.
Looks great, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browser.cdpHeadersfrom config files whenPLAYWRIGHT_MCP_CDP_HEADERSis unset.cdpHeadersoverrides from env parsing.tests/mcp/config.spec.ts.