Skip to content

feat(electron): add artifactsDir option to electron.launch()#39880

Merged
yury-s merged 1 commit intomicrosoft:mainfrom
yury-s:feat-electron-artifactsdir
Mar 26, 2026
Merged

feat(electron): add artifactsDir option to electron.launch()#39880
yury-s merged 1 commit intomicrosoft:mainfrom
yury-s:feat-electron-artifactsdir

Conversation

@yury-s
Copy link
Copy Markdown
Member

@yury-s yury-s commented Mar 26, 2026

Summary

  • Add artifactsDir option to electron.launch(), mirroring the same option in browserType.launch()
  • When specified, artifacts (downloads, traces, videos, etc.) are saved to the given directory and not cleaned up on close
  • When not specified, a temporary directory is created and cleaned up as before

Similar to browserType.launch(), allow specifying an artifacts directory
for Electron so that downloads, traces, videos etc. are saved to a
user-controlled location that is not cleaned up on close.
@yury-s yury-s merged commit d67f31e into microsoft:main Mar 26, 2026
37 checks passed
@yury-s yury-s deleted the feat-electron-artifactsdir branch March 26, 2026 18:50
@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests 1"

6 flaky ⚠️ [chromium-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/popup.spec.ts:261 › should not throw when click closes popup `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:758 › launchServer › should upload a folder `@webkit-ubuntu-22.04-node20`

38931 passed, 845 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "MCP"

5549 passed, 340 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants