chore: screencast clarity#39926
Merged
pavelfeldman merged 2 commits intomicrosoft:mainfrom Mar 30, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Mar 30, 2026
pavelfeldman
force-pushed
the
video_layers
branch
from
ad894ba to
2e45675
Compare
pavelfeldman
force-pushed
the
video_layers
branch
from
2e45675 to
ab45a04
Compare
Signed-off-by: Pavel Feldman <pavel.feldman@gmail.com>
yury-s
reviewed
Mar 30, 2026
| async startScreencast(options: { width: number; height: number; quality: number; }): Promise<void> { | ||
| await this._mainFrameSession._client.send('Page.startScreencast', { | ||
| startScreencast(options: { width: number; height: number; quality: number; }) { | ||
| this._mainFrameSession._client.send('Page.startScreencast', { |
| async stopScreencast() { | ||
| await this._mainFrameSession._client._sendMayFail('Page.stopScreencast'); | ||
| stopScreencast() { | ||
| this._mainFrameSession._client._sendMayFail('Page.stopScreencast').catch(() => {}); |
Member
There was a problem hiding this comment.
Suggested change
| this._mainFrameSession._client._sendMayFail('Page.stopScreencast').catch(() => {}); | |
| this._mainFrameSession._client._sendMayFail('Page.stopScreencast'); |
dgozman
approved these changes
Mar 30, 2026
Contributor
Test results for "MCP"1 failed 6279 passed, 350 skipped Merge workflow run. |
Contributor
Test results for "tests 1"3 failed 10 flaky39032 passed, 845 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.