Skip to content

chore: expose browser.bind and browser.unbind APIs#39972

Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:expose-browser-register
Mar 31, 2026
Merged

chore: expose browser.bind and browser.unbind APIs#39972
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:expose-browser-register

Conversation

@pavelfeldman
Copy link
Copy Markdown
Member

Summary

  • Make _register/_unregister public as register/unregister on Browser
  • Add API declarations in class-browser.md (since v1.52, JS-only)
  • Remove unnecessary as Browser/as any casts at all call sites

@pavelfeldman pavelfeldman force-pushed the expose-browser-register branch from 3dedc7c to 6b0d85b Compare March 31, 2026 17:50
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@pavelfeldman pavelfeldman force-pushed the expose-browser-register branch 2 times, most recently from 53c6e5a to 323ac84 Compare March 31, 2026 19:29
@pavelfeldman pavelfeldman force-pushed the expose-browser-register branch 3 times, most recently from 0028493 to c0b1b8d Compare March 31, 2026 19:50
@github-actions

This comment has been minimized.

@pavelfeldman pavelfeldman force-pushed the expose-browser-register branch from c0b1b8d to 1023792 Compare March 31, 2026 20:52
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@pavelfeldman pavelfeldman changed the title chore: expose browser.register and browser.unregister APIs chore: expose browser.bind and browser.unbind APIs Mar 31, 2026
@pavelfeldman pavelfeldman force-pushed the expose-browser-register branch from 1023792 to 67414c4 Compare March 31, 2026 21:49
@github-actions

This comment has been minimized.


Title of the browser server, used for identification.

### option: Browser.register.workspaceDir
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I register without a workspace dir?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Test results for "tests 1"

10 flaky ⚠️ [chromium-library] › library/video.spec.ts:481 › screencast › should capture static page in persistent context @smoke `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/video.spec.ts:280 › screencast › should capture navigation `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:724 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/popup.spec.ts:261 › should not throw when click closes popup `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:724 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:118 › screencast › should capture static page `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/video.spec.ts:652 › screencast › should capture full viewport `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/video.spec.ts:724 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node20`

39104 passed, 846 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Test results for "MCP"

1 failed
❌ [msedge] › mcp/files.spec.ts:106 › clicking on download link emits download @mcp-windows-latest

6298 passed, 370 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants