chore: enforce dispatcher API convention for server types (2)#40020
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Apr 2, 2026
| // Discard previous chunk if any and ignore any errors there. | ||
| await this.stopChunk(progress, { mode: 'discard' }).catch(() => {}); | ||
| await this.stop(progress); | ||
| await this.stopChunk(nullProgress, { mode: 'discard' }).catch(() => {}); |
Collaborator
There was a problem hiding this comment.
Why ignore the progress given here?
dgozman
approved these changes
Apr 2, 2026
pavelfeldman
force-pushed
the
progress_server_2
branch
from
6340766 to
b7556de
Compare
Contributor
Test results for "MCP"1 failed 6363 passed, 370 skipped Merge workflow run. |
Contributor
Test results for "tests 1"9 flaky39136 passed, 846 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.