fix(test): avoid dev matchers clobbering stable runner in reporter tests#40187
Open
yury-s wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(test): avoid dev matchers clobbering stable runner in reporter tests#40187yury-s wants to merge 1 commit intomicrosoft:mainfrom
yury-s wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Stop importing startHtmlReportServer from packages/playwright/lib/runner in reporter-html and reporter-blob tests. Instead, export a lightweight copy from playwright-test-fixtures that only depends on playwright-core HttpServer.
dgozman
approved these changes
Apr 13, 2026
Contributor
Test results for "MCP"7 failed 1 flaky6513 passed, 382 skipped Merge workflow run. |
Contributor
Test results for "tests 1"1 failed 10 flaky39173 passed, 846 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.60.0-alpha-2026-04-13, alltoMatchAriaSnapshotcalls inreporter-html.spec.tsandreporter-blob.spec.tsfail withtoMatchAriaSnapshot() must be called during the test.Root cause: Both test files imported
startHtmlReportServerfrom../../packages/playwright/lib/runner. This transitively loaded the dev code'smatchers/expect.jsbundle (viarunner → common → matchers/expect). Because jest-expect stores matchers onglobalThis[Symbol.for("$$jest-matchers-object")], the dev matchers overwrote the stable test runner's matchers. WhentoMatchAriaSnapshotwas later called, it executed the dev copy which references the dev code'sexpectConfig()— a module-level singleton wheretestInfowas never set (only the stable runner's worker sets it on its own copy). This was exposed by a120dec which changedtoMatchAriaSnapshotfrom usingglobals.currentTestInfo()(a shared global) toexpectConfig().testInfo(module-specific singleton).Fix: Replace the runner import with a lightweight
startHtmlReportServerhelper inplaywright-test-fixtures.tsthat only depends onplaywright-core'sHttpServer— no matchers loaded.Closes #40187