fix(mcp): ensure --proxy-server overrides config-file proxy#40212
Merged
yury-s merged 1 commit intomicrosoft:mainfrom Apr 16, 2026
Merged
fix(mcp): ensure --proxy-server overrides config-file proxy#40212yury-s merged 1 commit intomicrosoft:mainfrom
yury-s merged 1 commit intomicrosoft:mainfrom
Conversation
pavelfeldman
approved these changes
Apr 14, 2026
The CLI --proxy-server option previously set only launchOptions.proxy. If a config file set browser.contextOptions.proxy, browserFactory's spread order (contextOptions after launchOptions) caused the config file value to silently override the CLI value. Set the proxy on both launchOptions and contextOptions so the CLI consistently wins through the merge-and-spread pipeline. Fixes: microsoft#40204
yury-s
changed the title
Contributor
Test results for "MCP"3 failed 5997 passed, 916 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--proxy-serverwas silently overridden when a config file setbrowser.contextOptions.proxy, becausebrowserFactoryspreadscontextOptionsafterlaunchOptions.launchOptions.proxyandcontextOptions.proxyso the CLI consistently wins through the merge-and-spread pipeline.--proxy-serverrouting, one covering the CLI-overrides-config-file scenario.Fixes #40204