chore(dashboard): new buttons#40225
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Skn0tt
force-pushed
the
dashboard-polish
branch
from
0e644a3 to
8f34ffe
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Skn0tt
force-pushed
the
dashboard-polish
branch
3 times, most recently
from
84a947b to
13dd0bb
Compare
| await Promise.all([...this._attached.values()].map(att => att.setScreencastActive(params.visible))); | ||
| } | ||
|
|
||
| async reveal(params: { path: string }) { |
There was a problem hiding this comment.
Don't we have an open package dependency for this? Let's use it - we can iterate on this bit later on.
There was a problem hiding this comment.
Most people don't have a sensible default app for '.webm', so 'open' doesn't help. We need something more like https://github.com/sindresorhus/reveal-file, which is basically this. Let's keep what we have and iterate 👍
Skn0tt
force-pushed
the
dashboard-polish
branch
from
cd708a8 to
d3f159e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Skn0tt
force-pushed
the
dashboard-polish
branch
from
42f1de6 to
28aedd1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "MCP"6 failed 6038 passed, 976 skipped Merge workflow run. |
Test results for "tests 1"1 failed 2 flaky39189 passed, 847 skipped Merge workflow run. |
2 participants
Screen.Recording.2026-04-16.at.09.20.30.mov