chore(dashboard): show console and network data from tracing#40242
Merged
Conversation
Member
Skn0tt
commented
Apr 16, 2026
Skn0tt
commented
dgozman
approved these changes
Apr 16, 2026
| import { HttpServer } from '@utils/httpServer'; | ||
| import { makeSocketPath } from '@utils/fileUtils'; | ||
| import { gracefullyProcessExitDoNotHang } from '@utils/processLauncher'; | ||
| import { TraceLoader } from '@isomorphic/index'; |
Collaborator
There was a problem hiding this comment.
Please make the import more specific - this allows the bundler to pull less things.
| if (!tracesDir) | ||
| throw new Error('Traces directory is missing'); | ||
| const sha1 = url.pathname.split('/sha1/')[1]; | ||
| const loader = new TraceLoader(); |
Collaborator
There was a problem hiding this comment.
I think we should load this once, not upon every sha1 request.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"5 flaky39187 passed, 847 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 6056 passed, 976 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.