Skip to content

fix(mcp): throw clear error for tab creation in extension protocol v1#40261

Merged
yury-s merged 1 commit intomicrosoft:mainfrom
yury-s:fix-tab-creation-v1
Apr 17, 2026
Merged

fix(mcp): throw clear error for tab creation in extension protocol v1#40261
yury-s merged 1 commit intomicrosoft:mainfrom
yury-s:fix-tab-creation-v1

Conversation

@yury-s
Copy link
Copy Markdown
Member

@yury-s yury-s commented Apr 17, 2026

Summary

  • When tab-new is invoked with extension protocol v1 (default), Target.createTarget was not handled and fell through to forwardToExtension, causing a cryptic Cannot read properties of undefined (reading '_page') error.
  • Now intercepts Target.createTarget in the v1 handler and throws a clear "Tab creation is not supported yet" message.

When `tab-new` is invoked with extension protocol v1 (default),
`Target.createTarget` was not handled and fell through to
`forwardToExtension`, causing a cryptic "_page" error. Now throws
a clear "Tab creation is not supported yet" message.
@yury-s yury-s merged commit 2fb4b68 into microsoft:main Apr 17, 2026
8 of 9 checks passed
@yury-s yury-s deleted the fix-tab-creation-v1 branch April 17, 2026 00:25
@github-actions
Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/dashboard.spec.ts:77 › should activate session when show is called with -s @mcp-ubuntu-latest

6095 passed, 976 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants